Prepare shared code: Support running on non default dns settings #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sbernauer
reviewed
Oct 16, 2024
Techassi
previously requested changes
Oct 16, 2024
Just pushed my test fix, did not look at your changes. Dont plan on pushing more today (do a little testing) so feel free to add :) |
There is still some bits and pieces we want to change, mostly regarding the error type / error handling. This commit also moves the input fixtures for testing the resolv parser into dedicated files and utilizies rstest's #[files] attribute to generate tests based on these files. Co-authored-by: Nick Larsen <[email protected]>
Co-authored-by: Techassi <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
sbernauer
previously approved these changes
Oct 17, 2024
NickLarsenNZ
requested changes
Oct 17, 2024
Co-authored-by: Malte Sander <[email protected]> Co-authored-by: Techassi <[email protected]>
Co-authored-by: Malte Sander <[email protected]> Co-authored-by: Techassi <[email protected]>
sbernauer
approved these changes
Oct 17, 2024
nightkr
reviewed
Oct 18, 2024
Comment on lines
+630
to
+633
| let _ = KUBERNETES_CLUSTER_DOMAIN | ||
| .set(retrieve_cluster_domain().context(ResolveKubernetesClusterDomainSnafu)?); | ||
| create_client(field_manager).await | ||
| } |
|
|
||
| match env::var(KUBERNETES_SERVICE_HOST_ENV) { | ||
| Ok(_) => { | ||
| let cluster_domain = retrieve_cluster_domain_from_resolv_conf(RESOLVE_CONF_FILE_PATH)?; |
There was a problem hiding this comment.
If we're going to do this hack (and I still don't think we should), can we please at least punt that until vNext instead of sneaking it in just before the release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#436.
Definition of Done Checklist
Author
Reviewer
Acceptance