Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stackable-versioned): Forward selected kube args #873

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

Techassi
Copy link
Member

Part of stackabletech/issues#507

Forwards selected kube arguments.

Reviewer

sbernauer
sbernauer previously approved these changes Sep 23, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test it, but code looks good

crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
@Techassi Techassi marked this pull request as ready for review September 24, 2024 07:45
sbernauer
sbernauer previously approved these changes Sep 24, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@Techassi Techassi added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 34c6c4f Sep 24, 2024
10 checks passed
@Techassi Techassi deleted the feat/crd-versioning-forward-k8s-args branch September 24, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants