Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use emptyDir for segment cache #342

Closed
wants to merge 73 commits into from
Closed

[Merged by Bors] - Use emptyDir for segment cache #342

wants to merge 73 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Nov 14, 2022 •
edited
Loading

@maltesander
wip adapted CRD
2df5c34
@maltesander
adapted crds, added tls properties
9c98a2a
@maltesander
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
1bb0ea0 
…ation
@maltesander
adapted tests and examples
57d3783
@maltesander
adapted docs to new structure
ade2d85
@maltesander
wip - started tests
5fdf74d
@maltesander
code cleanup
07bcdbe
@maltesander
more restructureing
9542070
@maltesander
wip
3cce94a
@maltesander
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
16ab4a4 
…ation

# Conflicts:
#	deploy/crd/druidcluster.crd.yaml
#	deploy/helm/druid-operator/crds/crds.yaml
#	deploy/manifests/crds.yaml
@maltesander
wip
7ed6b6a
@maltesander
wip
967f8cc
@maltesander
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
f514b5d 
…ation

# Conflicts:
#	deploy/crd/druidcluster.crd.yaml
#	deploy/helm/druid-operator/crds/crds.yaml
#	deploy/manifests/crds.yaml
@maltesander
wip
fed8806
@maltesander
removed internal tls for now. started tests.
a57ce39
@maltesander
tls tests working
3b706dc
@maltesander
authentication working
4acc745
@maltesander
working on tests
e46da68
@maltesander
switched to clusterConfig
3a59475
@maltesander
wip
aab5ed5
@maltesander
wip
6665156
@maltesander
first tests passing after rework
6b35031
@maltesander
adapted other tests to new crd structure
2a022f4
@maltesander
adapted docs
b5b3655
@maltesander
updated test definition
870b494
@maltesander
adapted changelog
484c269
@maltesander
added example
7ffe15e
@maltesander
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
2fb3181 
…ation

# Conflicts:
#	CHANGELOG.md
#	rust/crd/src/lib.rs
#	rust/operator-binary/src/druid_controller.rs
@maltesander
first merging
55989bb
@maltesander
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
b2a5a9a 
…ation

# Conflicts:
#	rust/crd/src/lib.rs
@razvan razvan marked this pull request as ready for review November 15, 2022 16:09
@razvan razvan requested a review from a team November 15, 2022 16:09
@adwk67 adwk67 requested review from adwk67 and removed request for a team November 16, 2022 09:48
adwk67
adwk67 reviewed Nov 16, 2022
View reviewed changes
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
rust/crd/src/resource.rs Show resolved Hide resolved
rust/operator-binary/src/druid_controller.rs Outdated Show resolved Hide resolved
adwk67
adwk67 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@razvan
Copy link
Member Author

razvan commented Nov 16, 2022

bors merge

bors bot pushed a commit that referenced this pull request Nov 16, 2022
@maltesander
Use emptyDir for segment cache (#342)
1978a8e 
Fixes #306

🟢 CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/42/
@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Use emptyDir for segment cache [Merged by Bors] - Use emptyDir for segment cache Nov 16, 2022
@bors bors bot closed this Nov 16, 2022
@bors bors bot deleted the 306-segment-cache-size branch November 16, 2022 13:21
@sbernauer
Copy link
Member

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make segment-cache size configurable and use emptyDir for it
4 participants
@razvan @sbernauer @adwk67 @maltesander