Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove actions/cache in favor of actions/setup-python caching #288

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

kurtmckee
Copy link
Contributor

Description:

Currently, all CI jobs emit warnings due to actions/cache@v3, which uses an old Node.js version (recent example).

image

However, on inspection, it appears that actions/cache is configured incorrectly:

  • There are no lock files for it to hash, resulting in a blank portion in the cache key (caches generated in CI).

    image

  • The comments in the YAML claim that it's caching for pipenv, but then caches the pip directory instead.

    image

Therefore, this PR rips out actions/cache in favor of the Python caching already supported by actions/setup-python.

If this merges, please close #284.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
    n/a
  • Documentation has been updated to reflect changes, if applicable
    n/a
  • Changes are added to the changelog
    n/a

@jonhealy1 jonhealy1 self-requested a review August 23, 2024 11:56
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jonhealy1 jonhealy1 merged commit 516e968 into stac-utils:main Aug 23, 2024
15 checks passed
@kurtmckee kurtmckee deleted the rm-actions-cache branch August 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants