Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add free-text search extension #227

Merged
merged 6 commits into from
Aug 31, 2024
Merged

Add free-text search extension #227

merged 6 commits into from
Aug 31, 2024

Conversation

rhysrevans3
Copy link
Contributor

@rhysrevans3 rhysrevans3 commented Apr 12, 2024 •
edited
Loading

Description:

Adding the free-text search extension. Related to stac-utils/stac-fastapi#655

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@rhysrevans3
Copy link
Contributor Author

I've not included FreeTextAdvancedExtension as I don't think it works in it's current form and expect it will be removed in the future.

@rhysrevans3 rhysrevans3 marked this pull request as ready for review August 30, 2024 09:42
jonhealy1
jonhealy1 requested changes Aug 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jonhealy1 jonhealy1 self-requested a review August 30, 2024 13:29
jonhealy1
jonhealy1 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super

jamesfisher-geo
jamesfisher-geo approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@jamesfisher-geo jamesfisher-geo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great!

How do you feel about adding other fields like Collection and Item titles to the free-text search in the future?

@jonhealy1 jonhealy1 merged commit ae5588e into stac-utils:main Aug 31, 2024
15 checks passed
@rhysrevans3 rhysrevans3 deleted the free-text-search branch September 2, 2024 07:50
@rhysrevans3
Copy link
Contributor Author

@jamesfisher-geo yes I'll make a new pull request to add those fields. Alternately it could just search all fields instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

@jamesfisher-geo jamesfisher-geo jamesfisher-geo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhysrevans3 @jonhealy1 @jamesfisher-geo