Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional page argument to all_collections endpoint. #116

Closed
wants to merge 4 commits into from

Conversation

cbarton4
Copy link

Related Issue(s):

Description:
Adds an optional "page" argument for all_collections endpoint.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the changelog

@jonhealy1
Copy link
Collaborator

Hi @cbarton4 can you run pre-commit run --all-files? The gh actions are throwing some minor linting errors. Thanks!

@cbarton4
Copy link
Author

Apologies, missed that in the first go-around.

@philvarner
Copy link
Collaborator

I would prefer if this used the same search_after mechanism that item pagination does and that there be a "next" link in the collection response to get the next page of results, rather than a client just having to "know" that they need to add the page parameter.

Page should be fast enough with a relatively small number of collections (e.g., not millions), but I think there should be a next link so that clients can use that for pagination rather than hard-coding the use of page, which we may change in the future.

@cbarton4
Copy link
Author

cbarton4 commented Oct 6, 2022

That's fair. This is here if we want it in, and our local will likely use this in the short term. I'll look into adding a "next" link when I have time to revisit this, hopefully in the November timeframe.

@jonhealy1
Copy link
Collaborator

There is now a pt to finish this work here: #164

@jonhealy1 jonhealy1 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants