Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix id+key reporting in cli #206

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Fix id+key reporting in cli #206

merged 1 commit into from
Jul 28, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jul 28, 2024

Related issues and pull requests

Description

We were incorrectly assuming that asset keys were unique in the CLI reporting 🤦🏼. cc @drnextgis

Checklist

  • Update CHANGELOG

@gadomski gadomski self-assigned this Jul 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.03%. Comparing base (47cec93) to head (904c3ed).

Files Patch % Lines
src/stac_asset/_cli.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files          16       16           
  Lines        1049     1049           
=======================================
  Hits          892      892           
  Misses        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski merged commit d9ee425 into main Jul 28, 2024
9 checks passed
@gadomski gadomski deleted the issues/205-fix-cli-reporting branch July 28, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple error messages when failing fast
2 participants