Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-special-case search box on index page #1364

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jul 16, 2024

Related Issue(s):

Description:

The search box was embedded in the page, but that was not obvious and made the topbar search behave strangely. This PR makes the index page the same as the other pages.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (d9b354d) to head (d1635ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1364   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          51       51           
  Lines        7070     7070           
  Branches     1012     1012           
=======================================
  Hits         6439     6439           
  Misses        451      451           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsignell jsignell added this pull request to the merge queue Jul 19, 2024
Merged via the queue into stac-utils:main with commit c259549 Jul 19, 2024
24 checks passed
@jsignell jsignell deleted the search-docs branch July 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken search on docs
2 participants