Topic: fix queue subscription updating w/o changes

sst · Oct 2, 2024 · 2ed86c7 · 2ed86c7
1 parent 64a591a
commit 2ed86c7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/platform/src/components/aws/sns-topic-lambda-subscriber.ts b/platform/src/components/aws/sns-topic-lambda-subscriber.ts
@@ -1,6 +1,7 @@
 import {
   ComponentResourceOptions,
   Input,
+  jsonStringify,
   Output,
   output,
 } from "@pulumi/pulumi";
@@ -88,7 +89,7 @@ export class SnsTopicLambdaSubscriber extends Component {
             topic: topic.arn,
             protocol: "lambda",
             endpoint: fn.arn,
-            filterPolicy: JSON.stringify(args.filter ?? {}),
+            filterPolicy: args.filter && jsonStringify(args.filter),
           },
           { parent: self, dependsOn: [permission] },
         ),

diff --git a/platform/src/components/aws/sns-topic-queue-subscriber.ts b/platform/src/components/aws/sns-topic-queue-subscriber.ts
@@ -1,4 +1,9 @@
-import { ComponentResourceOptions, Input, output } from "@pulumi/pulumi";
+import {
+  ComponentResourceOptions,
+  Input,
+  jsonStringify,
+  output,
+} from "@pulumi/pulumi";
 import { Component, transform } from "../component";
 import { SnsTopicSubscriberArgs } from "./sns-topic";
 import { parseQueueArn } from "./helpers/arn";
@@ -81,7 +86,7 @@ export class SnsTopicQueueSubscriber extends Component {
             topic: topic.arn,
             protocol: "sqs",
             endpoint: queueArn,
-            filterPolicy: JSON.stringify(args.filter ?? {}),
+            filterPolicy: args.filter && jsonStringify(args.filter),
           },
           {},
         ),

diff --git a/platform/src/components/aws/sns-topic.ts b/platform/src/components/aws/sns-topic.ts
@@ -452,7 +452,7 @@ export class SnsTopic extends Component implements Link.Linkable {
           [
             typeof topicArn === "string" ? topicArn : outputId,
             JSON.stringify(args.filter ?? {}),
-            typeof queueArn === "string" ? queueArn : outputId,
+            queueArn,
           ].join(""),
           6,
         ),