Add support for ordering css variables declaration #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Css variables are not property declarations but considered customProperties by the parser adding this allows for custom properties like ``` --my-var: srowhani#123; ``` To be sorted as well
|
Seems like a nice quality of life change! Thanks for working on this. Could you add a test to accompany the feature - a simple test case being added, or an existing one modified to include css variables would do! |
|
@srowhani Sure, but there is an issue with sass-lint, it crashes with css variables currently, sasstools/sass-lint#1310 (quite the annoying bug..) Do you have the right to merge and publish the package on the other repo as it's marked unmaintained or should we publish a forked version? |
|
Tests are added, they will only pass with the fix on sass-lint applied as it's currently throwing a js error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Css variables are not property declarations but considered customProperties by the parser adding this allows for custom properties like
To be sorted as well