Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Allow plugins to hook into File > Open #22564

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jitseniesen
Copy link
Member

@jitseniesen jitseniesen commented Sep 24, 2024

This is work in progress, but I want some early feedback on design and stuff.

Description of Changes

This PR revives PR #8798. It provides a mechanism for plugins to register file extensions, so that if a user picks a file with that extension in the dialog window for File > Open, the file is opened in that plugin instead of the editor.

Here is what it looks like, if the necessary changes are made in the Notebook plugin:

open-notebook.mp4

Issue(s) Resolved

Fixes #22354
Fixes #7794

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Jitse Niesen

@pep8speaks
Copy link

pep8speaks commented Sep 24, 2024

Hello @jitseniesen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 46:1: E402 module level import not at top of file
Line 47:1: E402 module level import not at top of file
Line 87:1: E402 module level import not at top of file

Comment last updated at 2024-09-26 22:02:58 UTC

@jitseniesen jitseniesen added this to the v6.1.0 milestone Sep 24, 2024
@jitseniesen
Copy link
Member Author

@spyder-ide/core-developers I took the same approach as the previous PR by Carlos and I moved the code for File > Open from the Editor plugin to mainwindow.py. However, that file is already a big pile of unrelated stuff, so perhaps another location like one of the plugins would be better? If so, where? From looking at the names, the mainmenu or maybe the application plugin?

@ccordoba12
Copy link
Member

Thanks for working on this @jitseniesen! I opened PR #22576 as a prerequisite of your work because we need to remove some dead code that referenced the open, new, save actions in the Editor.

So, please rebase after that PR is merged.

@jitseniesen
Copy link
Member Author

So, please rebase after that PR is merged.

Thanks, done!

@jitseniesen
Copy link
Member Author

As discussed in the last Core Team meeting:

  • This PR will cover all the file actions: new, open, save, close.
  • Code goes in the Applications plugin.
  • The "new file" action opens a new file in the currently active pane, if possible. For example, if the user is working in the Notebook pane then File > New will open a new notebook.
  • These file actions only make sense for dockable plugins.
  • The Variable Explorer can use the "open file" action to open data files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide custom editor widget for given file extension via plugin Allow plugins to hook into File > Open
3 participants