Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnableReactiveMethodSecurity Supports Custom MethodSecurityExpressionHandler #15719

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

kse-music
Copy link
Contributor

Closes gh-15715

@jzheaux
Copy link
Contributor

jzheaux commented Sep 3, 2024

Thanks for this, @kse-music, though I'd prefer to start with #7459 - would you consider updating your PR to pick up a custom expression handler instead?

This Spring Framework enhancement may prove helpful, though I'm not certain.

@jzheaux jzheaux self-assigned this Sep 3, 2024
@jzheaux jzheaux added in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 3, 2024
@kse-music
Copy link
Contributor Author

kse-music commented Sep 4, 2024

@jzheaux Used Fallback to identify the default bean .When user not provide customized, the default will be used.

@kse-music kse-music changed the title Set PermissionEvaluator bean for MethodSecurityExpressionHandler Support custom MethodSecurityExpressionHandle in Reactive Sep 4, 2024
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kse-music! I've left some feedback inline.

Also, would you feel up to porting the Customizing Expression Handling section in the servlet documentation over to the reactive documentation? If so, please make the necessary modifications so it makes sense in the context of the reactive documentation. Or, if not, no problem, I can add that as a polish.

@kse-music
Copy link
Contributor Author

kse-music commented Sep 5, 2024

@jzheaux All feedback is completed as expected.But I don't quite understand why the Spring-Security-Docs: Antora ' task execute failed.

@jzheaux jzheaux changed the title Support custom MethodSecurityExpressionHandle in Reactive EnableReactiveMethodSecurity Supports Custom MethodSecurityExpressionHandler Sep 10, 2024
@jzheaux jzheaux merged commit fc3de5e into spring-projects:main Sep 10, 2024
6 checks passed
@jzheaux jzheaux added this to the 6.4.0-M4 milestone Sep 10, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Sep 10, 2024

Thanks, @kse-music, this is now merged into main along with a polish of be6dc1d to apply #15719 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
Status: No status
3 participants