Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC Logout docs: Session Strategy vs. Registry #15686

Conversation

hwanders
Copy link
Contributor

@hwanders hwanders commented Aug 23, 2024

Contents

This contains the following changes to the OIDC logout documentation:

  • replace OidcSessionStrategy by OidcSessionRegistry
  • replace ReactiveOidcSessionStrategy by ReactiveOidcSessionRegistry
  • fix broken/inconsistent Java code examples
  • fix syntax of adoc source code blocks -- same as in Fix code format in OIDC Logout docs #15566 to avoid conflicts if that one gets merged first

Furthermore a test name was adjusted to reflect the right terminology.

Reason

  • There is no OidcSessionStrategy in Spring Security, the demo code indicates that actually OidcSessionRegistry was meant

@pivotal-cla
Copy link

@hwanders Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@hwanders Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 23, 2024
@jzheaux jzheaux force-pushed the docs/oidc-logout-rename-session-strategy-to-registry branch from efae213 to 3c9099f Compare August 26, 2024 22:23
@jzheaux jzheaux changed the base branch from main to 6.2.x August 26, 2024 22:23
@jzheaux jzheaux merged commit 2ba9b68 into spring-projects:6.2.x Aug 26, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Aug 26, 2024

Thanks for the corrections, @hwanders! These are now merged into 6.2.x, 6.3.x, and main and should appear in the docs site shortly.

@jzheaux jzheaux self-assigned this Aug 26, 2024
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 26, 2024
@jzheaux jzheaux added this to the 6.2.7 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants