Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SortMergeBucketExample to Parquet + update tests #5191

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

clairemcginty
Copy link
Contributor

Updates SortMergeBucketExample to use Parquet writes (both typed and Avro) and demonstrate features like FilterPredicates, Projections, and Configurations. Also updates the unit tests to demonstrate the new SmbIO functionality as well as the smb-write Tap functionality.

Todo:

  • Update documentation to explain new testing methods and when to use JobTest vs SMB taps.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70b84c5) 62.62% compared to head (4f96abb) 62.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5191   +/-   ##
=======================================
  Coverage   62.62%   62.63%           
=======================================
  Files         301      301           
  Lines       10842    10842           
  Branches      767      767           
=======================================
+ Hits         6790     6791    +1     
+ Misses       4052     4051    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairemcginty clairemcginty marked this pull request as ready for review January 25, 2024 14:35
@clairemcginty clairemcginty merged commit 6abfbc4 into main Jan 29, 2024
12 of 13 checks passed
@clairemcginty clairemcginty deleted the parquetify-smb-example branch January 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants