refactor(client-http,web,server): use a serializable and more simple … #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Billlynch
requested review from
andreas-karlsson,
tonyskn,
ammar1x and
varmenise
as code owners
Billlynch
force-pushed
the
simple_configuration
branch
3 times, most recently
from
3d6b56d
to
9bf85c7
Compare
andreas-karlsson
previously approved these changes
Oct 26, 2023
Billlynch
force-pushed
the
simple_configuration
branch
from
a72d2c5
to
b011c53
Compare
andreas-karlsson
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…configuration object
Hi There, I just made a Pull Request!
Refactor to use a more simple configuration object. The aim to be simple to integrate with any adaptor when using the client-http directly. A key aim was also to ensure that the object is serialisable to enable better Next.js integrations down the road.
✔️ Checklist