Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspace star and no amend #192

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: workspace star and no amend #192

merged 2 commits into from
Aug 20, 2024

Conversation

nicklasl
Copy link
Member

@nicklasl nicklasl commented Aug 20, 2024

The hypothesis is that the amending of release pr should not be needed with the workspace:* approach on dev-dependencies.

@nicklasl nicklasl marked this pull request as ready for review August 20, 2024 12:35
@nicklasl nicklasl changed the title build: workspace star and no amend fix: workspace star and no amend Aug 20, 2024
Copy link
Contributor

@andreas-karlsson andreas-karlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's give it a try.

@nicklasl nicklasl merged commit 82c4f7d into main Aug 20, 2024
2 checks passed
@nicklasl nicklasl deleted the workspace-star-no-amend branch August 20, 2024 13:21
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants