Skip to content

Commit

Permalink
fix!: disable automatic visitor id for client environment
Browse files Browse the repository at this point in the history
since we are defaulting to disable (whereas it was previously enabled),
 we mark the commit as breaking.
  • Loading branch information
nicklasl committed Sep 6, 2024
1 parent 935a195 commit 274bacf
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions packages/sdk/src/Confidence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { Context } from './context';
import { Logger } from './logger';
import { FlagEvaluation, FlagResolver, State, StateObserver } from './flags';
import { SdkId } from './generated/confidence/flags/resolver/v1/types';
import { visitorIdentity } from './trackers';
import { Trackable } from './Trackable';
import { Closer } from './Closer';
import { Subscribe, Observer, subject, changeObserver } from './observing';
Expand Down Expand Up @@ -366,17 +365,13 @@ export class Confidence implements EventSender, Trackable, FlagResolver {
maxOpenRequests: (50 * 1024) / (estEventSizeKb * maxBatchSize),
logger,
});
const root = new Confidence({
return new Confidence({
environment: environment,
flagResolverClient,
eventSenderEngine,
timeout,
logger,
});
if (environment === 'client') {
root.track(visitorIdentity());
}
return root;
}
}

Expand Down

0 comments on commit 274bacf

Please sign in to comment.