fix: boot resource leakage

Introduced in #1137
spiral · Sep 29, 2024 · d2881dd · d2881dd
1 parent 9aea4d8
commit d2881dd
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/src/Boot/src/Memory.php b/src/Boot/src/Memory.php
@@ -36,16 +36,27 @@ public function loadData(string $section, string &$filename = null): mixed
 
         try {
             $fp = \fopen($filename, 'r');
+            if ($fp === false) {
+                return null;
+            }
+
             if (!\flock($fp, \LOCK_SH | \LOCK_NB)) {
+                \fclose($fp);
                 return null;
             }
+
             $data = include($filename);
+
             \flock($fp, \LOCK_UN);
-            \fclose($fp);
-            return $data;
         } catch (\Throwable) {
             return null;
+        } finally {
+            if (isset($fp)) {
+                \fclose($fp);
+            }
         }
+
+        return $data;
     }
 
     public function saveData(string $section, mixed $data): void