Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tornjak APIs in manager code #508

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Tornjak APIs in manager code #508

wants to merge 2 commits into from

Conversation

maia-iyer
Copy link
Collaborator

Closes #491

@maia-iyer maia-iyer added backend Tornjak API (Backend) manager Tornjak Manager labels Sep 30, 2024
@maia-iyer maia-iyer added this to the 1.9.0 milestone Sep 30, 2024
@maia-iyer maia-iyer self-assigned this Sep 30, 2024
@maia-iyer maia-iyer changed the title add methods to apis in manager code Update Tornjak APIs in manager code Sep 30, 2024
mamy-CS
mamy-CS approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the unused variable, /lgtm

api/manager/server.go Outdated Show resolved Hide resolved
@maia-iyer
remove dead code
2643d77 
Signed-off-by: Maia Iyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamy-CS mamy-CS mamy-CS approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees

@maia-iyer maia-iyer

Labels
backend Tornjak API (Backend) manager Tornjak Manager
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Update Manager to use Tornjak v1 api
2 participants
@maia-iyer @mamy-CS