Check missed events before start #5289
Conversation
Signed-off-by: Faisal Memon <[email protected]>
faisal-memon
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Signed-off-by: Faisal Memon <[email protected]>
|
@azdagron This is an important PR, being the one that closes 5151 and basically fixes the last of the known bugs in the database event processing. If you are back from your travels, a quick look today might help us move it faster when we have Tuseday's meeting. |
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
|
@amartinezfayo Would you please add this to the 1.10.1 release as was decided in the mainter's meeting on 7/16/2024? This is a critical bug fix. |
| if err := tx.Find(&events, "id > ?", req.GreaterThanEventID).Order("id asc").Error; err != nil { | ||
| return nil, sqlError.Wrap(err) | ||
|
|
||
| if req.GreaterThanEventID != 0 && req.LessThanEventID != 0 { |
There was a problem hiding this comment.
I suggest moving this check into buildListEventsQueryString. That body of that function only makes sense with the mutual exclusivity of these options in mind.
|
I'd suggest a high-level explanation of the algorithm used to detect missing events and event gaps somewhere in the code. Things are a bit hard to follow and digging up the GH issue isn't convenient for folks trying to understand the code. |
Signed-off-by: Faisal Memon <[email protected]>
Co-authored-by: Andrew Harding <[email protected]> Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Pull Request check list
Affected functionality
Events based cache
Description of change
missedStartupEvents()that checks for events below the first event we received.Which issue this PR fixes
fixes #5151