Allow specifying "ByExpiresBefore" in the "ListAgentsRequest_Filter" #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nico Weisenauer <[email protected]>
Signed-off-by: Nico Weisenauer <[email protected]>
nweisenauer-sap
requested review from
evan2645,
amartinezfayo,
azdagron and
rturner3
as code owners
|
Seems that #52 has implemented the same thing and has been merged, so this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to filter agents "ByExpiresBefore" on the server side allows for a more efficient implementation of pruning expired agent entries.
This is a prerequisite for a PR in spiffe/spire to allow "ListAgents" to filter "ByExpiresBefore".
Which problem does this solve for us?
This allows users to implement their own cleanup logic in a more efficient way by fetching only expired agents.
Ref: