feature: Add hint field to X509Certificate and JWTKey in bundle #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuhan Li <[email protected]>
loveyana
requested review from
evan2645,
amartinezfayo,
azdagron and
rturner3
as code owners
|
@loveyana So sorry for the delayed response on this PR. It wasn't quite clear how these fields might be used by consumers of the SPIFFE bundle. Would you mind opening an issue in this repository explaining the use case(s) you had in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we support downstream services through the methods of PublishJWTAuthority and AppendBundle in the authorized state. We hope to add a hint field to the X509Certificate and JWTKey in the Bundle, so that the hint information can be retrieved when invoke GetBundle.