Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Config Files with SPIRE Agent Default Socket Path and Fix README.md Table Formatting #102

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

maxlambrecht
Copy link
Member

@maxlambrecht maxlambrecht commented Nov 13, 2023

This PR includes updates to all configuration files, changing the SPIRE agent socket path to the default "/tmp/spire-agent/public/api.sock". Additionally, adjustments have been made to fix the formatting of the table in the README.md file.

@faisal-memon faisal-memon added this to the 0.8.0 milestone Dec 2, 2023
@faisal-memon
Copy link
Collaborator

@maxlambrecht Thanks for submitting this. Will it close #36?

@maxlambrecht
Copy link
Member Author

@maxlambrecht Thanks for submitting this. Will it close #36?

I'm not sure, this PR aligns the socket path in config files and docs with SPIRE's default, but it overlooks incorporating support for the standard environment variable to define that path.

@faisal-memon
Copy link
Collaborator

@maxlambrecht can you rebase?

@faisal-memon faisal-memon merged commit b9989da into spiffe:main Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants