-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining data store options #463
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kevin Fox <[email protected]>
Signed-off-by: Kevin Fox <[email protected]>
Co-authored-by: Faisal Memon <[email protected]> Signed-off-by: kfox1111 <[email protected]>
Co-authored-by: Faisal Memon <[email protected]> Signed-off-by: kfox1111 <[email protected]>
Needs support for:
|
Moving to separate issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally some document or unit test that ensures the sql plugin is configured to match the examples under https://github.com/spiffe/spire/blob/v1.10.0/doc/plugin_server_datastore_sql.md would be included, to ensure that we have the settings documented to correctly derive the examples.
@@ -88,6 +88,11 @@ kubectl delete crds clusterfederatedtrustdomains.spire.spiffe.io clusterspiffeid | |||
|
|||
We only support upgrading one major/minor version at a time. Version skipping isn't supported. Please see <https://spiffe.io/docs/latest/spire-helm-charts-hardened-about/upgrading/> for details. | |||
|
|||
### 0.24.X | |||
|
|||
We have added the remaining options needed for the SPIRE Server SQL data store plugin. We have removed `spire-server.dataStore.sql.plugin_data` section as it is no longer needed. If you are using it, please migrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throw an error if spire-server.dataStore.sql.plugin_data
exists with details they need to update the SQL plugin configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is done
@@ -101,7 +101,22 @@ plugins: | |||
DataStore: | |||
sql: | |||
plugin_data: | |||
{{ include "spire-server.datastore-config" . | nindent 10 }} | |||
{{ include "spire-server.datastore-config" . | nindent 8 }} | |||
{{- if ne .Values.dataStore.sql.rootCAPath "" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be suppressed, along without MySQL specific values, should be suppressed / errored if not set to mysql.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done
Signed-off-by: Kevin Fox <[email protected]>
@edwbuck Changes look good to me. Can you give final approval? |
We dont support all the spire server datastore sql plugin options. Add the missing ones.
Before the change, we only support: