Fix #786

spicywebau · Sep 22, 2023 · 118c8d1 · 118c8d1
1 parent e1e212d
commit 118c8d1
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## Unreleased
+
+### Fixed
+- Fixed a bug that occurred when pasting Neo input blocks that use the child block UI element and have descendants, where the descendants would disappear after updating visible field layout elements for the Neo field
+
 ## 3.9.0 - 2023-09-19
 
 ### Added

diff --git a/src/assets/dist/neo-main.js b/src/assets/dist/neo-main.js
diff --git a/src/assets/dist/neo-main.js.map b/src/assets/dist/neo-main.js.map
diff --git a/src/assets/src/input/Input.js b/src/assets/src/input/Input.js
@@ -318,7 +318,18 @@ export default Garnish.Base.extend({
     this._updateBlockChildren()
     this._updateButtons()
 
-    this._visibleLayoutElements[block.getId()] = block.getBlockType().getDefaultVisibleLayoutElements()
+    // Construct the block's visible layout elements, since they might not be the default visible
+    // layout elements for the block type, e.g. if pasting a block
+    const visibleLayoutElements = {}
+    block.$contentContainer.children('[data-layout-tab]').each((_, layoutTab) => {
+      const $layoutTab = $(layoutTab)
+      const tabUid = $layoutTab.attr('data-layout-tab')
+      visibleLayoutElements[tabUid] = []
+      $layoutTab.children('[data-layout-element]').each((_, layoutElement) => {
+        visibleLayoutElements[tabUid].push($(layoutElement).attr('data-layout-element'))
+      })
+    })
+    this._visibleLayoutElements[block.getId()] = visibleLayoutElements
 
     // Create any required child blocks, if this block has only one child block type
     const createChildBlocksIfAllowed = () => {