Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App layer crypto codec #780

Open
wants to merge 135 commits into
base: main
Choose a base branch
from
Open

App layer crypto codec #780

wants to merge 135 commits into from

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jun 13, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds a custom codec to encrypt the grpc protocol with xchacha20-poly1305
  • Derives a shared key between the server and client by using a diffie hellman key exchange
  • Adds a secrets manager (gcp for prod, yaml file on disk for dev)
  • Stores the server private key in the secrets manager
  • Creates a more locked down service account for cloud run (roles/logging.logWriter, roles/monitoring.metricWriter, roles/cloudsql.client, and roles/secretmanager.secretAccessor@REALM_tavern_encryption_private_key

TODO

  • Add secrets management interface
  • Add secrets impl as a file on disk for debug builds
  • Add GCP Secrets manager to Terraform
  • Add secrets impl in GCP HSM
  • Store crypto private key with secrets management interface
  • Prevent VScode from throwing lint warnings about env!
  • Update docs
  • Cleanup

Which issue(s) this PR fixes:

implants/lib/pb/src/xchacha.rs Outdated Show resolved Hide resolved
@hulto
Copy link
Collaborator Author

hulto commented Jul 12, 2024

An error (new to me) seems to occur intermittently image

Hasn't been an issue the last four commits.
Could have been an issue in the github actions env the other day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant