Add [Either,Option].orNull. Closes #86. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spebbe
reviewed
Feb 7, 2022
There was a problem hiding this comment.
At least for Option, there is already toNullable() which does the exact same thing except for not being a getter. I intentionally "hid" toNullable it a bit :) , since I'm worried that its existence and use might obscure the purpose of Option (and Either). I'm open to going either way with this though.
Like with the other two PRs, I'm sorry for not replying sooner.
|
Okay no worries. I don't have a strong opinion on this one. I noticed an open issue and went for it. I personally don't see a huge downside to their existence since the type captures the intent but I also appreciate the other side of the coin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.