Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snippetFromFile property to Snippet class #459

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Add snippetFromFile property to Snippet class #459

merged 1 commit into from
Aug 1, 2023

Conversation

goneall
Copy link
Member

@goneall goneall commented Aug 1, 2023

Fixes #130

@goneall goneall requested a review from kestewart August 1, 2023 00:07
kestewart
kestewart approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kestewart kestewart added this to the 3.0-rc2 milestone Aug 1, 2023
maxhbr
maxhbr approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall merged commit d8ad786 into main Aug 1, 2023
1 check failed
@goneall goneall deleted the issue130 branch August 1, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr maxhbr approved these changes

@kestewart kestewart kestewart approved these changes

Assignees
No one assigned
Labels
Profile:Software
Projects
None yet
Milestone
3.0-rc2
Development

Successfully merging this pull request may close these issues.

(re) introduce the snippetFromFile property in Snippet class
3 participants
@goneall @maxhbr @kestewart