Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete SpdxId #442

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Delete SpdxId #442

merged 1 commit into from
Jul 28, 2023

Conversation

zvr
Copy link
Member

@zvr zvr commented Jul 28, 2023

  • Removes the newly introduced SpdxId datatype

Recently merged #426 introduced a new Datatype without any restriction, SpdxId.

The last discussion in #426 (with @goneall and @davaya) was that it will be removed before merging.

There is the separate issue #36 for SpdxId and a separate PR #407 proposing it.

This PR reverts the addition until a decision is made.

@zvr zvr requested a review from goneall July 28, 2023 20:31
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - this should not have been merged in the first place

@goneall
Copy link
Member

goneall commented Jul 28, 2023

@zvr BTW - I noticed the spec-parser started failing - see #443

@kestewart
Copy link
Contributor

SPDXId - still needs discussion.

@goneall goneall merged commit 8dff2a3 into spdx:main Jul 28, 2023
1 check failed
@zvr zvr deleted the rm-spdxid branch July 28, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants