Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds serialization security use cases and improves formatting #425

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Adds serialization security use cases and improves formatting #425

merged 1 commit into from
Jul 28, 2023

Conversation

jeff-schutt
Copy link
Collaborator

As requested by the serialization team in the 2023-06-06 tech team meeting (see lines 69-76 of https://github.com/spdx/meetings/pull/347/files).

cc: @zvr @rnjudge @tsteenbe

@kestewart kestewart added this to the 3.0-rc2 milestone Jul 25, 2023
kestewart
kestewart approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement

goneall
goneall approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeff-schutt

maxhbr
maxhbr approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clearly a step in the right direction

@goneall goneall merged commit 89fab7a into main Jul 28, 2023
1 check passed
@goneall goneall deleted the serialization-use-case-updates branch July 28, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@maxhbr maxhbr maxhbr approved these changes

@kestewart kestewart kestewart approved these changes

@tsteenbe tsteenbe Awaiting requested review from tsteenbe

@rnjudge rnjudge Awaiting requested review from rnjudge

Assignees
No one assigned
Labels
Profile:Security
Projects
None yet
Milestone
3.0-rc2
Development

Successfully merging this pull request may close these issues.
4 participants
@jeff-schutt @goneall @maxhbr @kestewart