add CreationInfo to all Elements in json-ld examples #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneall
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Thanks @armintaenzertng - I like the approach of using the blank node.
armintaenzertng
force-pushed
the
update_json-ld_examples
branch
from
7ac5766
to
f9a3e0f
Compare
maxhbr
reviewed
Jul 14, 2023
| { | ||
| "type": "Tool", | ||
| "spdxId": "spdx-example:SPDXRef-Actor-LicenseFind-1.0", | ||
| "name": "LicenseFind-1.0" | ||
| "name": "LicenseFind-1.0", | ||
| "creationInfo": {"@id": "_:creationInfo1"} |
There was a problem hiding this comment.
Is there a reason, why you do not use this shorthand?
Suggested change
| "creationInfo": {"@id": "_:creationInfo1"} | |
| "creationInfo": "_:creationInfo1" |
There was a problem hiding this comment.
Thanks for the nudge, I realized that we have to change the context to have "@type": "@id" for creationInfo in order for this to work.
CreationInfo has been made mandatory again in spdx#401, so the examples have to be updated. Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
armintaenzertng
force-pushed
the
update_json-ld_examples
branch
from
f9a3e0f
to
6961d83
Compare
|
I replaced all occurrences of I also noticed that all DateTime were missing the "Z" at the end and added those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreationInfo has been made mandatory again in #401, so the examples have to be updated.
This uses the de-duplication method of extracting the CreationInfo as a blank node.