Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change nature to ObjectProperty for enums and object range #410

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Change nature to ObjectProperty for enums and object range #410

merged 1 commit into from
Jul 9, 2023

Conversation

goneall
Copy link
Member

@goneall goneall commented Jul 7, 2023

Fixes #409

@goneall goneall requested a review from zvr July 7, 2023 19:07
zvr
zvr approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these are correct.
I did not check whether there are more to be changed, but these can be merged.

maxhbr
maxhbr approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall merged commit a9fa95e into main Jul 9, 2023
1 check passed
@goneall goneall deleted the datatoobject branch July 9, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvr zvr zvr approved these changes

@maxhbr maxhbr maxhbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properties with a range of a class with properties should not be "Data Types"
3 participants
@goneall @zvr @maxhbr