Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linalg dialect ops #29

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Update linalg dialect ops #29

merged 7 commits into from
Nov 27, 2023

Conversation

amanda849
Copy link
Contributor

@amanda849 amanda849 commented Nov 10, 2023 •
edited
Loading

  • Update the syntax for the linalg.fill op that was changed in this commit.
  • Add an additional syntax for linalg.matmul to include an optional result type
  • Add an op for linalg.reduce

@codecov-commenter
Copy link

Codecov Report

Merging #29 (fba911e) into master (bddedc2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          16       16           
  Lines        1807     1808    +1     
=======================================
+ Hits         1708     1709    +1     
  Misses         99       99
Files Coverage Δ
mlir/dialects/linalg.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@amanda849 amanda849 marked this pull request as draft November 13, 2023 18:47
@amanda849 amanda849 changed the title Update linalg.fill syntax Update linalg.fill and linalg.matmul syntax Nov 13, 2023
@amanda849 amanda849 marked this pull request as ready for review November 13, 2023 21:40
@amanda849 amanda849 marked this pull request as draft November 16, 2023 16:58
@amanda849 amanda849 changed the title Update linalg.fill and linalg.matmul syntax Update linalg dialect ops Nov 16, 2023
@amanda849 amanda849 marked this pull request as ready for review November 16, 2023 21:42
@tbennun
Copy link
Contributor

tbennun commented Nov 22, 2023

Is this ready for review?

@amanda849
Copy link
Contributor Author

Yes, it's ready.

tbennun
tbennun approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbennun tbennun merged commit 5a9a019 into spcl:master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanda849 @codecov-commenter @tbennun