Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

April fixes #140

Merged
merged 34 commits into from
Apr 23, 2024
Merged

April fixes #140

merged 34 commits into from
Apr 23, 2024

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented Apr 17, 2024 •
edited
Loading

This PR fixes a number of bugs, implements compatibility changes, and updates several things. The following (potentially non-exhaustive) list provides an overview of the commited changes:

  • Update dependencies to address security vulnerabilities. Closes Bump follow-redirects from 1.15.5 to 1.15.6 #134, Bump webpack-dev-middleware from 5.3.3 to 5.3.4 #136, Bump express from 4.18.2 to 4.19.2 #137.
  • Add and enforce a style guideline (this is the reason behind the majority of the line changes in this PR).
  • Update copyright information / year.
  • Provide compatibility with hierarchical SDFGs, i.e., SDFGs generated from DaCe versions 0.16 and up. This is done with a backwards-compatibility layer to support older graphs both in serialization and deserialization. This is the second main source of changes.
  • Provide compatibility with SDFGs where only non-default property values are saved. Most of this is already supported, but issues were detected with collapsing / uncollapsing behavior. This is addressed in this PR.

phschaad and others added 23 commits January 25, 2024 08:59
@phschaad
Improve compatibility with hierarchical SDFGs
6988be1
@phschaad
Adapt to SDFG_list refactor
e7536c0
@phschaad
Update eslint rule
4fa299e
@phschaad
Backwards compatbility
ff420dc
@LeandroTreu
bind viewport to graph
48c8fe6
@LeandroTreu
Merge branch 'master' of https://github.com/spcl/dace-webclient
d2cffa4
@LeandroTreu
bind viewport to graph bounds && comments
01a2142
@LeandroTreu
first LOD optimizations
e8c0542
@LeandroTreu
minimap optimizations
443b284
@LeandroTreu
quickfix simple_draw after invisible check
cf6ded5
@LeandroTreu
added connector LOD
cc73e54
@LeandroTreu
first mousehandler optimizations (only highlight when close)
f330b93
@LeandroTreu
mousehandler highlighting optimization (only redraw on change)
cce8ee0
@LeandroTreu
arrowhead LOD
e3de51a
@LeandroTreu
fixed connectors rendered when invisible
3997726
@phschaad
gerge remote-tracking branch 'origin/ltreu-sa-hrendering' into hierar…
ffccaab 
…chical_sdfg_compat
@LeandroTreu
fixed edges rendered even if not visible
9c134be
@LeandroTreu
added loading animation for relayout tasks
c5ba20a
@LeandroTreu
added missing loading animation for settings change
5e00d44
@phschaad
gerge remote-tracking branch 'origin/ltreu-sa-hrendering' into hierar…
7b81479 
…chical_sdfg_compat
@phschaad
Update packages
e72214f
@phschaad
Merge branch 'hierarchical_sdfg_compat' into april_fixes
1ee6932
@phschaad
Updated requirements and workflows
b3fb00c
@phschaad phschaad mentioned this pull request Apr 17, 2024
Closed
@phschaad phschaad marked this pull request as ready for review April 22, 2024 08:27
@phschaad phschaad requested a review from tbennun April 22, 2024 08:28
@phschaad phschaad merged commit 8d5efa9 into master Apr 23, 2024
2 checks passed
@phschaad phschaad deleted the april_fixes branch April 23, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phschaad @tbennun @LeandroTreu