Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get/setNAV5PositionAccuracy #224

Merged
merged 8 commits into from
May 30, 2024

Conversation

cyclops1982
Copy link
Contributor

As asked/suggested/requested in #223.

This adds the option so set the pAcc parameter via UBX-CFG-NAV5.

The name of the method is somewhat strange. this is primarily because there is already a getPositionAccuracy.

Copy link
Collaborator

@PaulZC PaulZC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change setDynamicModel too. It needs the same |= change as per #223

Please add your new methods to keywords.txt

src/SparkFun_u-blox_GNSS_Arduino_Library.cpp Outdated Show resolved Hide resolved
src/SparkFun_u-blox_GNSS_Arduino_Library.cpp Outdated Show resolved Hide resolved
src/SparkFun_u-blox_GNSS_Arduino_Library.cpp Outdated Show resolved Hide resolved
src/SparkFun_u-blox_GNSS_Arduino_Library.cpp Outdated Show resolved Hide resolved
src/SparkFun_u-blox_GNSS_Arduino_Library.h Outdated Show resolved Hide resolved
@cyclops1982
Copy link
Contributor Author

Thanks @PaulZC - i think i got everything now.

Copy link
Collaborator

@PaulZC PaulZC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @cyclops1982 - thanks!
One very small change to make... ;-)

src/SparkFun_u-blox_GNSS_Arduino_Library.cpp Outdated Show resolved Hide resolved
@PaulZC PaulZC changed the base branch from main to release_candidate May 30, 2024 07:39
@PaulZC
Copy link
Collaborator

PaulZC commented May 30, 2024

Nice work Ruben - thanks!
Merging...

@PaulZC PaulZC merged commit 5582ed9 into sparkfun:release_candidate May 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants