Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed lab 2 - question 4b testcases to unicode strings. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed lab 2 - question 4b testcases to unicode strings. #6

wants to merge 1 commit into from

Commits on Jul 12, 2015

  1. Changed the testcases to unicode strings. 

    The RDD this function will be used on contains unicode strings.
This test uses default type strings, causing implementations of removePunctuation that use string.translate() to pass this test.
However string.translate() does not behave well for unicode strings, which cause cryptic errors later down the line (4c).
Aditionally positive test results for 4b wil confuse students debugging errors at 4c.
Changing the testcases to unicode strings better guides students towards using the regular expressions (re) module.
    @Jabokoe
    Jabokoe committed Jul 12, 2015
    Configuration menu
    Copy the full SHA
    e7fb432 View commit details
    Browse the repository at this point in the history