Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using z range in requirements.txt #909

Conversation

BradleySappington
Copy link
Collaborator

same as in poppy, lets allow all z updates for dependencies.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.85%. Comparing base (e22c3b1) to head (d39fa3d).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #909      +/-   ##
===========================================
+ Coverage    61.80%   61.85%   +0.05%     
===========================================
  Files           15       15              
  Lines         6941     6945       +4     
===========================================
+ Hits          4290     4296       +6     
+ Misses        2651     2649       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me

@BradleySappington BradleySappington merged commit 1c915ce into spacetelescope:develop Sep 4, 2024
9 of 10 checks passed
@BradleySappington BradleySappington deleted the z-range-for-dependencies branch September 4, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants