Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more robust intersection area computation #205

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

mcara
Copy link
Member

@mcara mcara commented Jul 17, 2024

Fixes a crash reported in https://jira.stsci.edu/browse/JP-3636 due to spherical_geometry raising MalformedPolygonError exception when computing area of some intersection polygons. Now, when this error is occurs, it is caught and the intersection area is set to 0. This has potential to result in sub-optimal order in which images will be aligned but in practice should have minimal effect.

@mcara mcara added the bug Something isn't working label Jul 17, 2024
@mcara mcara added this to the Better Awsomeness milestone Jul 17, 2024
@mcara mcara self-assigned this Jul 17, 2024
@mcara mcara requested a review from a team as a code owner July 17, 2024 13:22
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.68%. Comparing base (f91c66b) to head (cec7074).
Report is 1 commits behind head on main.

Files Patch % Lines
tweakwcs/wcsimage.py 76.47% 4 Missing ⚠️
tweakwcs/imalign.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   93.74%   93.68%   -0.07%     
==========================================
  Files          11       11              
  Lines        1999     2010      +11     
==========================================
+ Hits         1874     1883       +9     
- Misses        125      127       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcara
Copy link
Member Author

mcara commented Jul 17, 2024

JWST regression tests are running here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1608/

@mcara mcara requested a review from nden July 17, 2024 14:13
Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the code well, as far as I can follow, it looks good and regression tests are passing.

@nden
Copy link
Contributor

nden commented Jul 17, 2024

You need to submit a PR on jwst with a change log entry, saying this was fixed in tweakwcs and recording the PR number. Also bump the required version of tweakwcs once there is a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants