Notebook for using updated astrometry solutions #120
Conversation
|
Hmm. The built notebook is here: https://144-138342879-gh.circle-artifacts.com/0/root/repo/notebooks/DrizzlePac/using_updated_astrometry_solutions/using_updated_astrometry_solutions.html So it looks like it's not getting very far. The error is not terribly informative to me though. Do you think this might be because it's not an up-to-date enough version, @shannnnnyyy ? |
There was a problem hiding this comment.
The content looks good except for my pretty minor style/word choice suggestions.
I notice there's a commit in there with some un-cleared outputs. Normally I'd say squash that out, but it looks like it's just a traceback, rather than a figure which makes the file a lot more awkward to deal with. So we'll let it fly this time 😉
However, the notebook isn't currently executing as per my comment above. That'll need to be fixed before we can merge this...
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "# Using updated astrometry solutions" |
There was a problem hiding this comment.
I'm finding this title a bit hard to fully understand the context. Perhaps "Choosing alternate astrometry solutions for drizzling"?
(If you make the change here, it's probably good to also rename the file and directory)
There was a problem hiding this comment.
The context will usually be for drizzling, but not always so I think it might be best to keep it general. I'll brainstorm a title that makes more sense and gives more context.
There was a problem hiding this comment.
If it's ok with you I think i'll just leave this title for now, I can't think of anything better
There was a problem hiding this comment.
The idea was to keep it general, as I didn't want users to think this was something to ignore if they're not necessarily running drizzle. It's really applicable for any case where the WCS is used, as these are yielding different WCS's.
There was a problem hiding this comment.
Alright, point taken. Then we can leave it as is.
...books/DrizzlePac/using_updated_astrometry_solutions/using_updated_astrometry_solutions.ipynb
Outdated
Show resolved
Hide resolved
...books/DrizzlePac/using_updated_astrometry_solutions/using_updated_astrometry_solutions.ipynb
Outdated
Show resolved
Hide resolved
...books/DrizzlePac/using_updated_astrometry_solutions/using_updated_astrometry_solutions.ipynb
Outdated
Show resolved
Hide resolved
...books/DrizzlePac/using_updated_astrometry_solutions/using_updated_astrometry_solutions.ipynb
Outdated
Show resolved
Hide resolved
…updated_astrometry_solutions.ipynb Co-Authored-By: Erik Tollerud <[email protected]>
…updated_astrometry_solutions.ipynb Co-Authored-By: Erik Tollerud <[email protected]>
…updated_astrometry_solutions.ipynb Co-Authored-By: Erik Tollerud <[email protected]>
…updated_astrometry_solutions.ipynb Co-Authored-By: Erik Tollerud <[email protected]>
eteq
force-pushed
the
astrometry-workflow-wfc3
branch
from
efed67b
to
170baab
Compare
|
I pushed up a few fixes since that was going to be faster than suggesting them (I'd already run the notebook locally), but I think this is now running correctly. It's still mysterious that the check box appeared even though the notebook was failing, but that's #121 now. So this is probably good if @shannnnnyyy is ok with the changes I made. |
|
@eteq everything looks good to me! |
Added a notebook to the DrizzlePac subdirectory with how to access and use the updated astrometry solutions for wfc3 and acs data. This will only run with the latest version of stwcs (and drizzlepac as well I believe - to be safe I put the latest version as the minimum in the requirements).