Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test PyPI action to GitHub Publishing Workflow #99

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jaymedina
Copy link
Collaborator

@jaymedina jaymedina commented Oct 6, 2023

Closes #102

  • Successful upload to Test PyPI with Twine instead of OpenAstronomy action
  • Trigger run after being labeled publish-to-test
  • Incrementally increase version number based on what already exists in Test PyPI

@jaymedina jaymedina marked this pull request as draft October 6, 2023 13:18
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@jaymedina jaymedina added publish-to-test Build & publish feature branch to Test PyPI before merge and removed publish-to-test Build & publish feature branch to Test PyPI before merge labels Oct 7, 2023
@jaymedina jaymedina added publish-to-test Build & publish feature branch to Test PyPI before merge and removed publish-to-test Build & publish feature branch to Test PyPI before merge labels Oct 7, 2023
@jaymedina jaymedina added publish-to-test Build & publish feature branch to Test PyPI before merge and removed publish-to-test Build & publish feature branch to Test PyPI before merge labels Oct 7, 2023
@jaymedina jaymedina added publish-to-test Build & publish feature branch to Test PyPI before merge and removed publish-to-test Build & publish feature branch to Test PyPI before merge labels Oct 8, 2023
@jaymedina jaymedina added publish-to-test Build & publish feature branch to Test PyPI before merge and removed publish-to-test Build & publish feature branch to Test PyPI before merge labels Oct 8, 2023
@jaymedina jaymedina added publish-to-test Build & publish feature branch to Test PyPI before merge and removed publish-to-test Build & publish feature branch to Test PyPI before merge labels Oct 8, 2023
@jaymedina jaymedina self-assigned this Oct 8, 2023
@jaymedina jaymedina removed the publish-to-test Build & publish feature branch to Test PyPI before merge label Oct 8, 2023
@jaymedina jaymedina marked this pull request as ready for review October 8, 2023 21:16
@jaymedina jaymedina requested a review from falkben October 8, 2023 21:16
@jaymedina
Copy link
Collaborator Author

jaymedina commented Oct 8, 2023

Let me know what you think of the versioning for this @falkben . Ideally, I would have liked to keep the versioning syntax that's used in the official pypi releases, but that seemed tricky to do, although I didn't explore the solutions enough.

I went with defining each version based on the date/time of the current run, which is simple. This is what a release looks like on Test PyPI:
image

Users CAN choose to download from Test PyPI so I wonder if we should keep our version numbers the same as how we write them in PyPI.

Edit: David suggests versioning with commit hash, and mentions that it can also point directly to the latest commit before the release to Test PyPI took place, so this sounds like it would be very useful.

@jaymedina jaymedina added enhancement New feature or request publish-to-test Build & publish feature branch to Test PyPI before merge and removed publish-to-test Build & publish feature branch to Test PyPI before merge enhancement New feature or request labels Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request publish-to-test Build & publish feature branch to Test PyPI before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action to relase to Test PyPI for each merge
1 participant