bindings/go: Fix bug in RangeText function #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
reviewed
May 2, 2024
bindings/go/scip/source_file.go
Outdated
| @@ -69,7 +69,7 @@ func (d *SourceFile) String() string { | |||
| // RangeText returns the substring of the source file contents that enclose the provided range. | |||
| func (d *SourceFile) RangeText(position Range) string { | |||
| result := strings.Builder{} | |||
| for line := position.Start.Line; line < position.End.Line; line++ { | |||
| for line := position.Start.Line; line <= position.End.Line && int(line) < len(d.Lines); line++ { | |||
There was a problem hiding this comment.
Not sure if I'm reading this right, can we use line <= math.Min(position.End.Line, d.Lines - 1) or something here?
can probably normalise the start line as well with respect to 0/d.Lines bounds
There was a problem hiding this comment.
Good point, this function already assumes the range is in bounds, so this was the wrong fix. I've simplified this to only do line <= position.End.Line. The caller can do bounds checks if needed, or recover from the panic if the range is not in bounds.
varungandhi-src
force-pushed
the
vg/fix-RangeText
branch
from
eb66178
to
d9cdd41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
Fixes ENG-23731
Test plan
Added unit tests