Test Command #236
Merged
Test Command #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/scip/test.go
Outdated
Comment on lines
106
to
107
| // the type of attribute that this is | ||
| kind string |
There was a problem hiding this comment.
Please make this an enum, not a string
|
@varungandhi-src amusingly long delay on this one, but finally got around to make your suggestions Should be ready for another round of reviews! |
Comment on lines
+133
to
+136
| testCases := []TestCase{ | ||
| {"roles", | ||
| autogold.Expect("✓ passes.repro (3 assertions)\n"), | ||
| autogold.Expect(`✗ fails-wrong-role.repro |
There was a problem hiding this comment.
@matthewnitschke-wk I've added snapshot tests here for checking the output, so that we don't accidentally regress something (earlier, this test was just checking for pass/fail instead of checking the output).
varungandhi-src
approved these changes
Sep 26, 2024
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestTestCasesForLine(t *testing.T) { |
There was a problem hiding this comment.
@matthewnitschke-wk Thank you for adding this test, it compactly expresses the different kinds of syntax that are available and how they get parsed. Nice!
|
@matthewnitschke-wk I've cut a new v0.5.0 release with the test subcommand. |
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the proposal specified here: #235
Closes #235