Included diagnostics in scip snapshot
output
#220
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concept originally came out of this issue, which was individually reported in
sourcegraph/scip
within this issueAdds the option to include indexed diagnostics to the results of
scip snapshot
This functionality is explicitly enabled via the
--include-diagnostics
flag, to support backwards compatibility with current snapshot tests (eg, the inclusion ofdiagnostics
in snapshot files is opt-in)Example format is as follows:
scip snapshot --include-diagnostics
will result inTest plan
repolang
and how to add diagnostic concepts to it. I'm open to suggestions / contributions to the pr addressing this missing test coverage