Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sorting CLI options #188

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Stop sorting CLI options #188

merged 3 commits into from
Jul 21, 2023

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Jul 19, 2023

Fixed in https://github.com/urfave/cli/releases/tag/v2.19.2

Test plan

scip snapshot -h

Before

OPTIONS:
   --comment-syntax value  Comment syntax to use for snapshot files (default: "//")
   --from value            Path to SCIP index file (default: "index.scip")
   --help, -h              show help (default: false)
   --project-root value    Override project root in the SCIP file. For example, this can be helpful when the SCIP index was created inside a Docker image or created on another computer
   --strict                If true, fail fast on errors (default: true)
   --to value              Path to output directory for snapshot files (default: "scip-snapshot")

After

OPTIONS:
   --from value            Path to SCIP index file (default: "index.scip")
   --to value              Path to output directory for snapshot files (default: "scip-snapshot")
   --project-root value    Override project root in the SCIP file. For example, this can be helpful when the SCIP index was created inside a Docker image or created on another computer
   --strict                If true, fail fast on errors (default: true)
   --comment-syntax value  Comment syntax to use for snapshot files (default: "//")
   --help, -h              show help (default: false) 

Less bugs, more features

    $ go get -u github.com/urfave/cli/v2
    go: upgraded github.com/urfave/cli/v2 v2.19.3 => v2.25.7
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Thank you!

@olafurpg olafurpg merged commit a395b45 into sourcegraph:main Jul 21, 2023
2 of 3 checks passed
@abitrolly abitrolly deleted the no-sort branch July 21, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants