Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit correct occurrences for destructured objects #185

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Commits on Oct 18, 2022

  1. Emit correct occurrenes for destructured objects

    Previously, scip-typescript didn't emit appropriate occurrences for
    `property` in the destructuring pattern below:
    ```ts
    interface Props { property: number }
    const prop = { property: 42 }
    const { property } = prop
    //      ^^^^^^^^ before: was a local reference
    //               now: local definition + global reference
    ```
    The solution works similarly to how to handle shorthand property
    definitions.
    olafurpg committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    de68fc7 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Address review feedback

    olafurpg committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0ee10af View commit details
    Browse the repository at this point in the history