1712-stepper-bug-that-causes-frontend-crash

[hanscau]

Description

Fix second statement being a ReturnStatement in a BlockStatement. The first statement should be reduced before going to the return statement.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvements

How to test

Tests already exists, the expected case was just wrong.

Checklist

• I have tested this code

[coveralls]

Pull Request Test Coverage Report for Build 10777371951

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.001%) to 81.525%

---

Totals
Change from base Build 10756964754:	0.001%
Covered Lines:	10921
Relevant Lines:	13029

---

💛 - Coveralls

[martin-henz]

hard to follow the complex logic of reduction of blocks. This PR is not making it worse, and is fixing the given issue. So: best we merge this. (Eventually we should consider simplifying the stepper design.)

[FYL2003]

Just some ideas: maybe breaking the big chunk of code into small functional pieces(each function into separate ts files) and add more comment on how the code words would help people better understand the code base.

[martin-henz]

The main problem is that the stepper implementation is not closely aligned with the specs. I think we need a re-implementation from scratch to make the stepper maintainable. I'll form a CP3108 project on this next semester.