This repository has been archived by the owner on Oct 14, 2022. It is now read-only.
Fix typo in control key specification #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After careful inspection of all the publication as well as the current implementations, it is clear that this has to be a typo in the README. For violation witnesses we can always use sink nodes to mark certain branches as unreachable / to cut the portion of state space that follows them, so `control` should really be seen as a pure source code guard.
danieldietsch
approved these changes
Nov 30, 2020
SvenUmbricht
approved these changes
Nov 30, 2020
dbeyer
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
According to the literature, this is a typo.
See comment #14 (comment) for more information.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After careful inspection of all the publication as well as the
current implementations, it is clear that this has to be a typo
in the README. For violation witnesses we can always use sink
nodes to mark certain branches as unreachable / to cut the portion
of state space that follows them, so
controlshould really beseen as a pure source code guard.
This addresses issue #14.