Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/#763] hot post #778

Merged
merged 7 commits into from
Jul 24, 2024
Merged

[feature/#763] hot post #778

merged 7 commits into from
Jul 24, 2024

Conversation

chattymin
Copy link
Member

@chattymin chattymin commented Jul 24, 2024

What is this issue?

  • hot-post 개발
  • app-serivce api 수정
  • interceptor 수정
스크린샷 2024-06-10 오후 3 39 26

@chattymin chattymin requested a review from a team as a code owner July 24, 2024 00:58
Copy link

height bot commented Jul 24, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@@ -45,7 +45,7 @@ class AuthInterceptor @Inject constructor(
}

private fun isAccessTokenUsed(originalRequest: Request) = when {
originalRequest.url.encodedPath.contains("playground") -> false
originalRequest.url.encodedPath.contains("auth/playground") -> false
Copy link
Member Author

@chattymin chattymin Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

playground가 들어가면 header를 넣지 않는 코드였습니다. 이 코드로 인해 403에러가 발생하고 있었습니다.
이번에 구현한 api에 playground가 들어가지만, header가 필요해 수정했습니다.
api명세서를 전부 뒤져보니 playground가 들어가는 api가 auth/playground 만 존재하여 해당 방법으로 수정했습니다.

Copy link
Member

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@chattymin chattymin merged commit f17f86e into develop Jul 24, 2024
1 check passed
@chattymin chattymin deleted the feat/#763-hot-post branch July 24, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants