[feature/refactor-code-structure] 홈쪽 코드 로직 개편 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2hyunwoo
force-pushed
the
feature/refactor-code-structure
branch
from
ff6f9dd
to
3a76f0a
Compare
l2hyunwoo
force-pushed
the
feature/refactor-code-structure
branch
from
44bbd5e
to
75f2a2c
Compare
code lint apply [feature/refactor-code-structure] NullableWrapper 삭제 Mypage 초기화면 코드 정리 User activeState 변수명 변경 MainView -> Home 패키지 명 변경 및 Home에 사용되는 모델들 Ui/Domain 분리 Generation Domain 로직 설정 및 Home 로직 개편 StartArgs 삭제 Home에서 사용하는 데이터 클래스 분리 및 참조 변경 apply ktlintFormat
l2hyunwoo
force-pushed
the
feature/refactor-code-structure
branch
from
75f2a2c
to
e24d369
Compare
|
홈화면 이상없게 수정해놨습니다. |
yxnsx
reviewed
Sep 26, 2023
Comment on lines
+66
to
+83
| private fun requestNotificationPermission() { | ||
| // This is only necessary for API level >= 33 (TIRAMISU) | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { | ||
| if (ContextCompat.checkSelfPermission(this, Manifest.permission.POST_NOTIFICATIONS) == | ||
| PackageManager.PERMISSION_GRANTED | ||
| ) { | ||
| // FCM SDK (and your app) can post notifications. | ||
| } else if (shouldShowRequestPermissionRationale(Manifest.permission.POST_NOTIFICATIONS)) { | ||
| // TODO: display an educational UI explaining to the user the features that will be enabled | ||
| // by them granting the POST_NOTIFICATION permission. This UI should provide the user | ||
| // "OK" and "No thanks" buttons. If the user selects "OK," directly request the permission. | ||
| // If the user selects "No thanks," allow the user to continue without notifications. | ||
| } else { | ||
| // Directly ask for the permission | ||
| requestNotificationPermissionLauncher.launch(Manifest.permission.POST_NOTIFICATIONS) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
이 부분 tiramisu under는 어떻게 처리되나욥,,?
There was a problem hiding this comment.
광고 id 받는건 api 33 이후라서 아레 버전에선 동작 안해도 될 것 같습니다.
app/src/main/java/org/sopt/official/feature/home/model/HomeCTAType.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/official/feature/home/model/HomeMenuType.kt
Outdated
Show resolved
Hide resolved
| @@ -1,7 +1,7 @@ | |||
| package org.sopt.official.domain.entity | |||
|
|
|||
| enum class UserState { | |||
| enum class UserActiveState { | |||
There was a problem hiding this comment.
걍 질문인데 UserActiveState(이전 UserState)랑 UserStatus랑 정확한 차이가 뭔가여
솝트 활동 상태 / Auth 상태..?
There was a problem hiding this comment.
중복해서 쓰고 있는듯…후우…이것도 적폐척결해야됨
yxnsx
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this issue?