New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/hilt-ksp] Apply ksp on hilt #329

Merged

l2hyunwoo merged 1 commit into develop from feature/apply-ksp-when-using-hilt

Sep 9, 2023

Member

l2hyunwoo commented Sep 9, 2023

What is this issue?

hilt 2.48 버전 이후로 ksp 적용이 가능해져서 ksp 적용을 해봤습니다. 빌드 시간 대폭 감축이 예상됩니다(포포리에서는 빌드속도가 10분 -> 7분 정도로 바뀌었습니다)
그런데 databinding은 여전히 kapt를 사용하고 있어서 kapt를 완전히 사용하지 않으려면 databinding 사용 코드를 제거해야할 것 같은데, 시간 되시면 데이터 바인딩 코드는 앞으로 사용을 자제해주시고 사용하고 있는 코드는 viewbinding 기반 혹은 compose로 전환해주시면 좋을 것 같습니다. @hjh1161514 @yxnsx @kimdahyee


          [feature/hilt-ksp] Apply ksp on hilt

5f3e252

l2hyunwoo self-assigned this

l2hyunwoo requested a review from a team as a code owner

September 9, 2023 03:33

pull-request-size bot added the size/S label

l2hyunwoo merged commit b4cc8fc into develop

1 check passed

l2hyunwoo deleted the feature/apply-ksp-when-using-hilt branch

September 9, 2023 03:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels